PR #24492 opened by michaelni
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/24492
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/24492.patch

Found-by: zhang xingxing

Signed-off-by: Michael Niedermayer <[email protected]>



>From 4e3484f5fb5e82baaa374afe1bef1e7923899f67 Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <[email protected]>
Date: Mon, 14 Sep 2026 19:01:00 +0200
Subject: [PATCH] avfilter/afir: do not normalize an impulse response that sums
 to zero

Found-by: zhang xingxing

Signed-off-by: Michael Niedermayer <[email protected]>
---
 libavfilter/afir_template.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavfilter/afir_template.c b/libavfilter/afir_template.c
index 10dc677c20..c652a2b9dc 100644
--- a/libavfilter/afir_template.c
+++ b/libavfilter/afir_template.c
@@ -64,13 +64,13 @@ static ftype fn(ir_gain)(AVFilterContext *ctx, 
AudioFIRContext *s,
     } else if (s->ir_norm == 0.f) {
         for (int i = 0; i < cur_nb_taps; i++)
             sum += time[i];
-        ch_gain = 1. / sum;
+        ch_gain = sum ? 1. / sum : 1;
     } else {
         ftype ir_norm = s->ir_norm;
 
         for (int i = 0; i < cur_nb_taps; i++)
             sum += POW(FABS(time[i]), ir_norm);
-        ch_gain = 1. / POW(sum, 1. / ir_norm);
+        ch_gain = sum ? 1. / POW(sum, 1. / ir_norm) : 1;
     }
 
     return ch_gain;
-- 
2.52.0

_______________________________________________
ffmpeg-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to