John Cox <jc <at> kynesim.co.uk> writes: > >> +#define UNCHECKED_BITSTREAM_READER 1 > > > >I don't think that's right, and is a security issue. > > I added that line as (nearly) every other decoder in > liavcodec has it -
Sure? > in particular h264_cabac.c has it. Extensive testing was done before it was added. Could you confirm how much of the speedup comes only from this change? While we definitely all welcome a noticeable speedup of hevc decoding (and while my opinion on your patch has limited relevance) I believe that the patch absolutely has to be split: First step would be to have a split between changes in the general code and changes to arm assembly, I believe the first patch then may be split further. I am a little surprised that you wrote some asm functions that are slower than what the compiler produces: Did you analyze this? Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
