On Sat, Apr 30, 2016 at 10:12:11AM -0400, Ronald S. Bultje wrote: > Hi, > > On Sat, Apr 30, 2016 at 9:02 AM, Carl Eugen Hoyos <ceho...@ag.or.at> wrote: > > > > cane please revert this patch? > > > I don't think there's wide support for it. > >
> > Two developers seem to wait for an explanation why it should be reverted. i think this comment is not helping to resolve things, its possibly also not accurate, i wasnt waiting on anything in case iam the 2nd devel, i just worked on other things and did not read this thread for a day or 2 > > > Last time I checked, commits were not free-for-all, but should be done only > after main concerns have been addressed. > > I've raised a main concern, and several developers have expressed support > for the concern. > > The patch should not have been committed. The patch was posted to the mailing list and noone objected to it or asked to wait, it was commited 2 weeks after being posted. > Please revert it. I would like to see the oppinion of the people who maintain the mpeg ts demuxer before its reverted. MAINTAINERs lists Marton for mpegts.c in practice i did try to maintain the code a bit over the last few years as well, mostly because noone else did it ... Maintaince burden was mentioned in this thread. I think the oppinion of the people maintaining the code thus is important If people want my oppinion, iam not sure if these 3 lines of code would cause more burden than the potential of redebuging and re-fixing this issue if a 2nd such file is found. I think if the fix is removed it should at least be replaced by a av_log warning so no time is wasted in debuging this again [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings concord. Out of discord comes the fairest harmony. -- Heraclitus
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
