On Sun, May 08, 2016 at 05:18:40PM +0200, Hendrik Leppkes wrote:
> On Sun, May 8, 2016 at 12:10 PM, Michael Niedermayer
> <mich...@niedermayer.cc> wrote:
> > Fixes Ticket5467
> >
> > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc>
> > ---
> > libavcodec/avcodec.h | 4 ++++
> > libavcodec/utils.c | 2 ++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index 3813a0a..1db2e0f 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -4050,6 +4050,10 @@ typedef struct AVCodecParameters {
> > * Audio only. Number of samples to skip after a discontinuity.
> > */
> > int seek_preroll;
> > +
> > + /** Properties, like FF_CODEC_PROPERTY_LOSSLESS.
> > + */
> > + int properties;
> > } AVCodecParameters;
> >
>
> There properties are not part of any container we support and therefor
> not really fitting into this structure.The documentation of AVCodecParameters says "This struct describes the properties of an encoded stream." lossless-ness is certainly a property of an encoded stream i dont think restricting a structure from libavcodec by the existence of demuxers for formats in libavformat is a good or clean design. its also not really true, that this isnt stored in containers avi for example has dwQuality which in conjunction with the codec_tag can probably be used to detect lossless ness for some codec_tags [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number that the same ideas make their appearance in the world. -- Aristotle
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
