Thanks for review. If qmin and qmax are not set, nvenc will assume default of qmin 15 and qmax 51 which is good enough for most content. Setting qmin 5 would be similar to qmin of 15 at lower bitrates as ratecontrol may not reach below QP 15.
Ganapathy -----Original Message----- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Philip Langdale Sent: Tuesday, February 28, 2017 5:54 AM To: Miroslav Slugeň <thunde...@email.cz> Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH] Remove qmin and qmax constraints for nvenc vbr On Tue, 28 Feb 2017 11:54:32 +0100 Miroslav Slugeň <thunde...@email.cz> wrote: > Dne 28.2.2017 v 10:44 Timo Rothenpieler napsal(a): > > Am 28.02.2017 um 01:24 schrieb Ganapathy Raman Kasi: > >> Can someone please help review patch. Thanks. > > I have seen an marked it, but I don't have time to review and test > > stuff right now. > > Will get to it eventually. > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > I tested this patch, it looks like there is no difference when you set > -qmin 5 -qmax 51 or leave it unset. > > BUT this patch is correct, NVENC doesn't require QMIN and QMAX for > 2pass vbr. > > M. > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Patch looks good to me too. Timo, I can push it if you don't mind not testing it yourself. --phil _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
