On Tue, 28 Feb 2017 11:54:32 +0100 Miroslav Slugeň <thunde...@email.cz> wrote:
> Dne 28.2.2017 v 10:44 Timo Rothenpieler napsal(a): > > Am 28.02.2017 um 01:24 schrieb Ganapathy Raman Kasi: > >> Can someone please help review patch. Thanks. > > I have seen an marked it, but I don't have time to review and test > > stuff right now. > > Will get to it eventually. > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > I tested this patch, it looks like there is no difference when you > set -qmin 5 -qmax 51 or leave it unset. > > BUT this patch is correct, NVENC doesn't require QMIN and QMAX for > 2pass vbr. > > M. > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Patch looks good to me too. Timo, I can push it if you don't mind not testing it yourself. --phil _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel