On 11/7/2017 10:04 AM, Timo Rothenpieler wrote: > Am 07.11.2017 um 13:28 schrieb Carl Eugen Hoyos: >> Hi! >> >> Attached patch fixes compilation with current libressl, related to >> ticket #6801. >> >> Please comment, Carl Eugen > > Wouldn't it be better to move that check to configure, so it does not > build the openssl backend with libressl, and then merge the libtls > backend that's been posted, so there is proper support for libressl > instead of an ever growing collection of #ifdefs?
I would very much rather have a way to get libressl to compile with tls_openssl.c, or just reject it altogether, than adding a duplicate module just for a fork that pretends to be compatible with a version of openssl but not providing the required API for it. I refuse to give special treatment to such a sloppy fork, especially when adding it would increase the complexity in configure (As only one tls module can be compiled per build). An "if not defined libressl" for every openssl >= 1.1 check is simpler and easier to maintain than a whole separate duplicate module. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
