On 11/7/2017 12:15 PM, Hendrik Leppkes wrote: > On Tue, Nov 7, 2017 at 2:57 PM, James Almer <jamr...@gmail.com> wrote: >> On 11/7/2017 10:48 AM, Hendrik Leppkes wrote: >>> On Tue, Nov 7, 2017 at 1:28 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >>>> Hi! >>>> >>>> Attached patch fixes compilation with current libressl, related to ticket >>>> #6801. >>>> >>> >>> I believe we basically had that exact same patch on the ML before, and >>> the consensus was to not have a jungle of #ifdefs in the code, and >>> instead have configure figure it out. >> >> configure could at most refuse to compile tls_openssl with libressl, but >> nothing to make it build successfully without ifdeffery. >> >> Is that preferred? > > I meant to have configure figure out properly if OpenSSL 1.1 API is > available, and not repeat that check in the code several times, which > is growing more complex now. > > - Hendrik
So you mean replacing "#if OPENSSL_VERSION_NUMBER >= 0x1010000fL && !defined(LIBRESSL_VERSION_NUMBER)" with "#if CONFIG_OPENSSL_1_1" or similar? Should be easy and agree it's slightly cleaner. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
