Le sextidi 26 brumaire, an CCXXVI, Jeyapal, Karthick a écrit :
> Thanks for the feedback. I have a relevant condition check so that
> only a real URLContext is returned.
> Please find the new patch attached.

I think that would work, thanks.

But I see that in the other patches you call ffio_geturlcontext()
without checking its return value. That is not good at all, and that
would make Coverity squirm.

If you are sure that you are always calling it with a real URLContext,
then make the test an av_assert0(). I think it is the case. Otherwise,
you need to check the return value.

Also, I see the other patch calling prot->url_write directly: I think it
should call ffurl_write() instead.


  Nicolas George

Attachment: signature.asc
Description: Digital signature

ffmpeg-devel mailing list

Reply via email to