On Wed, 24 Oct 2018, James Almer wrote:
On 10/24/2018 6:43 PM, Marton Balint wrote:
On Tue, 23 Oct 2018, Henrik Gramner wrote:
On Tue, Oct 23, 2018 at 3:22 PM Derek Buitenhuis
<derek.buitenh...@gmail.com> wrote:
I'd like to point out that this patch or some variant may be required
anyway.
libx264 only uses strtok_r or strtok_s if available on the platform.
See:
https://git.videolan.org/?p=x264.git;a=blob;f=common/osdep.h;h=715ef8a00c01ad5a94de2b29a422429b9b1f0a53;hb=HEAD#l75
The real fix is to bundle a strtok_r implementation, or to just outright
require strtok_r/strtok_s. Sad, I know.
What platforms that x264 supports don't have it anyway?
Honestly no idea, probably something obscure.
Well, then maybe x264 configure should simply fail for those.
I pushed the patch, once the strtok fix is merged to stable and we know
the build number, the flag can be re-introduced with an #if.
Regards,
Marton
This should be backported to supported branches, or at least 2.8, 3.2,
3.4 and 4.0
I did it for 4.0, I leave the rest for others.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
