> On 7 Mar 2019, at 23:57, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2019-03-06 15:57 GMT+01:00, Oliver Collyer <ovcoll...@mac.com>: >> Hi >> >> I needed the dynamic resolution changing feature of NVENC to be accessible >> through the ffmpeg libraries for a hobby project, so I added support and >> here is a patch. >> >> I will format this as a proper patch after any changes necessary following >> feedback. >> >> To use this feature you would need to: >> >> 1. Specify max_width and max_height before opening the encoder > > Can't they be set to a maximum number to be as flexible as possible? >
It would allocate the output surfaces to this size if we took that approach and I don’t think that is particularly sensible given this feature a pretty edge use case? > >> + av_log(avctx, AV_LOG_VERBOSE, >> + "resolution change: %d x %d -> %d x %d\n", >> + params.reInitEncodeParams.encodeWidth, >> + params.reInitEncodeParams.encodeHeight, > >> + (uint32_t)avctx->width, >> + (uint32_t)avctx->height); > > These casts look strange and should be unneeded. > No idea where those came from, I blame my fingers. Will remove. > Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
