tor 2019-03-14 klockan 17:55 +0000 skrev Yufei He:
> Hi
>
> Here is the patch for a new H.264 codec with Matrox m264 card.
>
> Please review.
> --- a/libavcodec/codec_desc.c
> +++ b/libavcodec/codec_desc.c
> @@ -1705,7 +1705,6 @@ static const AVCodecDescriptor
> codec_descriptors[] = {
> .long_name = NULL_IF_CONFIG_SMALL("Gryphon's Anim
> Compressor"),
> .props = AV_CODEC_PROP_LOSSY,
> },
> -
> /* various PCM "codecs" */
> {
> .id = AV_CODEC_ID_PCM_S16LE,
> diff --git a/libavcodec/m264dec.c b/libavcodec/m264dec.c
Stray hunk?
> + #ifdef _WIN32
> + lib_handle = dlopen("mvM264Ffmpeg.dll", RTLD_LAZY);
> + #else
> + lib_handle = dlopen("libmvM264Ffmpeg.so", RTLD_LAZY);
> + #endif
Still dlopen() I see. You should link to these libraries properly, as
others have said, and add appropriate license stuff to configure.
/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
