Michael Niedermayer <[email protected]> added the comment: On Wed, Mar 11, 2009 at 03:36:25PM +0000, Reimar Döffinger wrote: > On Wed, Mar 11, 2009 at 03:30:59PM +0000, Reimar Döffinger wrote: > > > Michael, Could you elaborate a little on the 'wrongs' in the sugested fix?
reimar already pointed at some problems ... > > > > Because "buffer_start + length == buffer_end", thus the <= seems > > correct, and the < should be wrong. I think it would discard the last > > part of each packet unless there is some extra junk/padding at the end. > > Oh, and in addition the checks are wrong since they do not take into > account overflow for pointer arithmetic. in addition to all that, someone should check the netgem patch (issue678) that contains various changes to dvbsubdec some very obvious bugfixes. i dont have the time to split and clean it sadly [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras ____________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/roundup/ffmpeg/issue536> ____________________________________________________
