Reynaldo H. Verdejo Pinochet <[email protected]> added the comment:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hello
wg wrote:
[..]
> everything works fine with all samples that I have. The parser is now
> also slightly smaller and more efficient, as it doesn't keep
> re-examining the complete packet for segments.
>
> Please take a look -- the diff is long; but it's probably better to
> look at it as a rewrite.
Seems OK though I don't really know this code well enough to
comment with ease.
- - if (p + len + 6 <= p_end)
- - {
- - *poutbuf_size += len + 6;
+ /* parse newly obtained segments */
+ while (pc->cursor < pc->packet_index) {
+ if (pc->packet_buf[pc->cursor] == 0x0f) {
+ if (pc->cursor + 6 <= pc->packet_index) {
+ int len = AV_RB16(pc->packet_buf + pc->cursor + 4);
Double check if these conditions can't be joined please, It looks
like they might.
I can commit if it passes Michael's or some other more acquainted
devs' review.
Best regards
- --
Reynaldo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkn3YPIACgkQwY4HfzEURSovXQCfbXjP59feYKsOFKb2xJj7gUDI
9VMAnA9FIR2HPpmqBazL7jjLwxyII7Vy
=lpLY
-----END PGP SIGNATURE-----
____________________________________________________
FFmpeg issue tracker <[email protected]>
<https://roundup.ffmpeg.org/roundup/ffmpeg/issue536>
____________________________________________________
