yoav <[email protected]> added the comment:
The last fix in r19291 seems incomplete. It doesn't handle the id3v2.3 extended
headers length correctly and assumes they use a syncsafe length which is wrong
(only id3v2.4 use it).
Here's my patch:
===================================================================
--- id3v2.c (revision 23012)
+++ id3v2.c (working copy)
@@ -188,7 +188,7 @@
}
if (isv34 && flags & 0x40) /* Extended header present, just skip over it */
- url_fskip(s->pb, get_size(s->pb, 4));
+ url_fskip(s->pb, version==3 ? get_be32(s->pb) : get_size(s->pb, 4));
while (len >= taghdrlen) {
if (isv34) {
----------
status: closed -> open
substatus: fixed -> needs_changes
________________________________________________
FFmpeg issue tracker <[email protected]>
<https://roundup.ffmpeg.org/issue1234>
________________________________________________
