yoav <[email protected]> added the comment: Running over my sample data again I couldn't find any problematic files. When I originally fixed issue1234 for myself I also added the the provided logic (reading id3v2.3 extended header size as a non syncsafe length) so I though it should probably also be fixed here. But it turns out that in id3v2.3 the extended header size can be either 10 or 6 bytes long (based on documentation and all my samples), making it compatible with both get_be32(s->pb) and get_size(s->pb, 4), so it doesn't really matter which function you use since the read value is never large enough to care about being syncsafe. The proposed patch in my previous post seems more correct, but in practice it doesn't matter. Sorry for opening this bug.
________________________________________________ FFmpeg issue tracker <[email protected]> <https://roundup.ffmpeg.org/issue1234> ________________________________________________
