[Fink-devel] serious libtool bug ?

[Max Horn]

Hi there,

I wanted to work on evolution 1.2.1, which needs gal 0.22. Since Masanori is on vacation or so, I looked into packaging it myself for now.


I quickly discovered that for once, they apparently have kept binary compatibility to the previous version. Looking at their configure.in:

From the respective configure.in files:

gal-0.21:
GAL_AGE=0
GAL_REVISION=0
GAL_CURRENT=21

gal-0.22:
GAL_AGE=1
GAL_REVISION=0
GAL_CURRENT=22

So it would seem they should be binary compatible. Indeed the filenames are
libgal.21.0.0.dylib and libgal.21.1.0.dylib


But otool -L yields:
libgal.21.0.0.dylib:
/sw/lib/libgal.21.dylib (compatibility version 22.0.0, current version 22.0.0)
libgal.21.1.0.dylib:
/sw/lib/libgal.21.dylib (compatibility version 23.0.0, current version 23.0.0)


Looking at the verstring calculation in their ltmain.sh (which is identical to that in libtool 1.4.3):

# Like Linux, but with the current version available in
# verstring for coding it into the library header
major=.`expr $current - $age`
versuffix="$major.$age.$revision"
# Darwin ld doesn't like 0 for these options...
minor_current=`expr $current + 1`
verstring="-compatibility_version $minor_current -current_version $minor_current.$revision"


I don't see how this is supposed to work, ever. Please somebody convince me this is not totally bogus code!
In particular I would think the second last line really should be:

minor_current=`expr $major + 1`


Otherwise, age is not handled right, as is visible in the above concrete example.

Comments? Am I nuts and this is right code in libtool after all? If so, please explain why. Or do you think it's buggy, too? Tell us!. But maybe my suggested fix is wrong, too? Fine, please explain why and tell us how to do it right, if possible, I'd love to know & fix it.


Cheers,

Max
--
-----------------------------------------------
Max Horn
Software Developer


-------------------------------------------------------
This SF.NET email is sponsored by: FREE SSL Guide from Thawte
are you planning your Web Server Security? Click here to get a FREE
Thawte SSL guide and find the answers to all your SSL security issues.
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en
_______________________________________________
Fink-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/fink-devel