- Check license, make sure it is correct
- Emacs modules: must comply with emacs policy (/sw/share/doc/emacsen-common/debian-emacs-policy)
- Use a unified diff for patches
- patch files should be reasonable size, and all patches should be necessary (no accidental patching of backup files, no patching of .am files uncessarily)
-Ben
Begin forwarded message:
From: Ben Hines <[EMAIL PROTECTED]>
Date: May 31, 2003 1:04:34 PM PDT
To: mathias meyer <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
Subject: [Fink-devel] Validating fink packages
On Saturday, May 31, 2003, at 09:16 AM, mathias meyer wrote:
if there are some things to do (like checking md5sum fields a while ago) where you might apprechiate some help let me know, i'm happy to do that.
I you want to, I would appreciate help validating new fink packages from the tracker... usually i check:
- fink validate on the .deb file and the .info file
- dpkg -c on the deb file just to make sure... make sure to do this for each splitoff.
- Check for hardcoded /sws in the info and patch (should be %p)
- Check for them touching anything outside of %d or %b during build and install. Not legal except in very special cases.
- Make sure license and Homepage is in the package and is right
- Make sure Maintainer is in the package and is the person who submitted the package. If not make sure they have the maintainer's permission.
- Check dependencies, run something like this: 'dpkg -L wml | xargs otool -L' will list all libraries linked to by everything in that package. make sure it depends on each (didnt someone make a perl script to do that?.. i think so), and make sure none are BuildDependsOnly.
- Try to check builddepends as much as possible (can be hard to get them all sometimes)
- Make sure description is readable and appropriate
- Sometimes I will let them know if they are doing crazy build hacks they don't need to be doing
- Let them know if they are missing fink fields, like if they have a ..conf file but forgot ConfFiles: field, or are not using fields like ConfigureParams:
- Make sure they have splitoffs if they include shared libraries, and comply with the full -shlibs policy if necessary.
- Make sure library versions in the Shlibs: field are correct.
- python modules: must comply with fink python policy
- perl modules: must comply with fink perl module policy
