On Oct 13, 2010, at 10:25 AM, Benny Malengier wrote:
> Another way to indicate a class inheriting from DiffusionTerm may not be > added to that class should be found in my opinion. Eg, one can have a class > membervalue (like class.ADDITIONTERM) indicating with what term the class can > be added. So new terms have to explicitly declare to what to add them, > instead of storing this in equation.py. That would allow me having this > custom term in my implementation without requiring to patch fipy to include > it. I completely agree that hard-coding everything in equation.py is a lousy design. It worked and we had other things to do, but I've never been happy with it. Your alternative is an interesting one that I'll need to think about. > PS: some other things in that patch are no longer needed due to the great > speedup in trunk now on adding meshes. Thanks for that ! I do still need a > more elaborate periodic mesh however and my editor pylint check chokes on > combining tabs with 4 spaces in a py file.... I'll look over the rest of your patches (I know several of these apply to bugs you filed a couple of months ago; we've been busy!)
