On 03/01/12 20:48, Adriano dos Santos Fernandes wrote: > On 01/03/2012 13:39, Adriano dos Santos Fernandes wrote: >> On 01/03/2012 13:26, Dimitry Sibiryakov wrote: >>> 01.03.2012 17:17, Adriano dos Santos Fernandes wrote: >>>> I understand a problem, but please talk about the solution you're >>>> proposing. What is the moment(s) a password should be converted, and >>>> from what to UTF8? >>> Sorry, but I don't have a solution for this problem. I would say that >>> password must be >>> converted by client library from current session/process/thread locale, >>> but... >>> >> I don't think it should. You're going to introduce another way to deal >> with connection parameters. >> >> If it's going to happen, it must be completely different and work for >> all properties. The correct solution is to create a notion of the >> "system charset" to be used as client charset. >> >> Worse, in Windows what should this system charset be in the case of >> console programs. It's not simple, console programs may be called by >> GUI's one in background. >> >> Also, sure, password must be converted to UTF8 when the user is created >> or it's password is modified, using the current charset to UTF8. >> >> Currently we already have the isc_dpb_utf8_filename, used inclusive for >> the password. It's the way one should pass it, and I don't think we >> should insert a hack here. >> >> > Looking again at sources, currently a mix of these two worlds are used, > which I still affirm I don't like too much, but may be better only if we > had intl libraries in the client. > > So, the password (and all other data) is converted if > isc_dpb_utf8_filename is not used. This may have bugs, specially in the > services mode, I'd say. > > So if it don't work in 2.5, it must be some of these bugs or that the > password is not converted before store it on the users database.
I'm afraid this should better not be touched in 2.5. Or people may have logon problems after upgrade. But in trunk we should better do all this correctly. Not sure that conversion is DPB/SPB is very good solution - passwords were never passed over the wire as text except when managing sec-Db. Converting right before passing to plugin seems to be simpler solution. ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
