Hello, can someone comment on the usefulness of this flag, please?

class dsql_req : public pool_alloc<dsql_type_req>
{
....
        static const unsigned FLAG_EMBEDDED                     = 0x02;

It's only used in dsql.cpp, inside DSQL_execute()

        if ((SSHORT) in_msg_type == -1)
                request->req_flags |= dsql_req::FLAG_EMBEDDED;

and a few lines below

        if (!(request->req_flags & dsql_req::FLAG_EMBEDDED))
        {
                request->execute(tdbb, tra_handle, in_blr_length, in_blr,
in_msg_length, in_msg,
                        out_blr_length, out_blr, out_msg_length, out_msg,
singleton);
        }

Elegant, but for this task, I just can test the original condition in the
second place and avoid a flag that doesn't have presence in any other place
of the code. I mean,

if (in_msg_type != MAX_USHORT)
{
        request->execute(...);
}

What am I missing?

C.
---
Claudio Valderrama C. - www.cvalde.net
Consultant, SW developer.


------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to