Claudio,

> Hello, can someone comment on the usefulness of this flag, please?
>
> class dsql_req : public pool_alloc<dsql_type_req>
> {
> ....
>       static const unsigned FLAG_EMBEDDED                     = 0x02;
>
> It's only used in dsql.cpp, inside DSQL_execute()
>
>       if ((SSHORT) in_msg_type == -1)
>               request->req_flags |= dsql_req::FLAG_EMBEDDED;
>
> and a few lines below
>
>       if (!(request->req_flags&  dsql_req::FLAG_EMBEDDED))
>       {
>               request->execute(tdbb, tra_handle, in_blr_length, in_blr,
> in_msg_length, in_msg,
>                       out_blr_length, out_blr, out_msg_length, out_msg,
> singleton);
>       }
>
> Elegant, but for this task, I just can test the original condition in the
> second place and avoid a flag that doesn't have presence in any other place
> of the code. I mean,
>
> if (in_msg_type != MAX_USHORT)
> {
>       request->execute(...);
> }
>
> What am I missing?

Nothing, as far as I see.


Dmitry

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to