> -----Original Message-----
> From: Alex Peshkoff [mailto:peshk...@mail.ru] 
> Sent: Lunes, 03 de Marzo de 2014 5:28
> 
> On 03/02/14 11:32, Claudio Valderrama C. wrote:
> > Hello, I have two doubts concerning gbak in v3:
> >
> > 1.- Should rdb$linger be stored in the backup?
> 
> I think yes

Done, not committed yet.
Should inf.cpp have an item to report dbb_linger_seconds or not?


> > 2.- Is this a small bug?
> >     // TYPE relation attributes
> >     att_type_name = SERIES,
> >     att_type_type,
> >     att_type_field_name,
> >     att_type_description,
> >     att_type_system_flag,
> >     // Also see att_type_description2 below!
> >
> >     // Filter attributes
> >     att_filter_name,
> > -> why is it not reset? I mean:
> >     att_filter_name = SERIES,
> 
> Appears correct. But is this new for v.3 gbak? If not this 
> promises to 
> break restore of old backups.

Unfortunately, it's old bug, so we leave it.


> > 3.- We have this in restore for rdb$relation_fields:
> > case att_field_character_length:
> >     field->fld_character_length = (USHORT) get_numeric(tdgbl);
> >     break;
> >
> > However, as the old comment indicates
> > SSHORT fld_character_length; // only assigned in 
> restore.epp but never used.
> >
> > Should we backup it?
> >
> 
> If it's really not used anywhere else (i.e. comment is correct) - not.

Cleaned.

C.


------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to