On 04/05/14 17:48, Dimitry Sibiryakov wrote: > 05.04.2014 13:33, Dimitry Sibiryakov wrote: >> Ok. Here is second version of the patch. Exactly as you like: a >> lot of code with >> blackjack and templates. > > Pardon: bigger code means more places for bugs. Here is a fixed patch. >
2 questions. 1. Where from did you get an estimation that 3 is enough? + static const int MAX_UNDO_RECORDS=3; 2. I see later in the code that in worst case MAX_UNDO_RECORDS may be overflowed, causing bugcheck. Why not use HALF_STATIC_ARRAY here to avoid it? + Record* tra_undo_records[MAX_UNDO_RECORDS]; // Storage for undo records for external use. Fixed array for speed. ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees_APR Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
