On 04/05/2015 08:04, Alex Peshkoff wrote:
> On 04/30/15 18:18, Adriano dos Santos Fernandes wrote:
>> I think this change (and maybe before it too) is wrong.
>>
>> If one creates a "User1", you should not create USER1. Nor "úser2"
>> should be ÚSER2.
> But ASCII users used to be case-insensitive from the beginning of 
> firebird. Here is an extract from PWD_verify_user() in firebird 1.0:
> if (user_name)
>      {
>      for (p = name, q = user_name; *q; q++, p++)
>      *p = UPPER7 (*q);
>      *p = 0;
>      }
>
> I do not know a place in docs where it's explicitly mentioned. But 
> "sysdba" is used in lower case in samples in ib6 beta doc from Borland.

Everything regarding to users is being changed in FB 3.

Every time I try Jaybird I need to figure out how to make it work.

So I expect we at least do the right things completely.


>> User names should respect quoted identifier rules, when quoted. So only
>> unquoted ASCII characters should be uppercased.
>>
>> There may be an exception, in DPB tags. AFAIK, roles were uppercased if
>> DPB does not have quotes. I think this is weird, but maybe it should be
>> equal for user names.
>>
>> I also didn't understood why did you inserted a new unicode upper-case
>> table, since that were already available and usable. But I didn't fully
>> reviewed the patch.
> This is much simpler to explain. Existing upper-caser depends upon ICU, 
> and I did not want to add it as dependency to fbclient.
>
>
And why user names should be upper cased in the client?


Adriano


------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to