> -----Original Message-----
> From: Dmitry Yemanov [mailto:firebi...@yandex.ru] 
> Sent: MiƩrcoles, 10 de Junio de 2015 15:40
> >
> > With the old logic, the result is one. With the new logic, 
> the result is two
> > becaise we get the direct and indirect effects.
> 
> I doubt the new logic would return two. These counters are 
> per-request 
> and trigger is a separate request, so its changes shouldn't 
> be counted 
> for the parent request.
> 
> > DSQL's get_request_info() retrieves not only the changes 
> but the selected
> > records, too so we still need to filter out those.
> 
> Sure, the idea was to sum up only I/U/D counters.
> 
> > Has anybody thought what will we reported in the extreme 
> event of more than
> > 2^32 updated or deleted records? The counters are going to 
> overflow because
> > they are ULONG in the engine.
> 
> What a cruel world ;-)

Somebody will have to fix the cruel world the day it became common to update
2^33 records.
:-)

For the moment, I changed the code and I'm going to commit in the next days.
BTW, it's exactly CORE-4817.

C.


------------------------------------------------------------------------------
Firebird-Devel mailing list, web interface at 
https://lists.sourceforge.net/lists/listinfo/firebird-devel

Reply via email to