02.03.2016 21:43, Dmitry Yemanov wrote: > Everyone is allowed to participate. Not everyone is allowed to commit > without a code review. This is a rule of thumb for any open-source project.
You should decide if the project needs more manpower or years long queue of pull requests. > Your patches have been discussed and partially applied, but no decision > was made regarding the rest of the changes. I still have doubts about > them. This patch was sent to you for review two years ago. Yes, two years. Exactly one year ago you picked couple of pieces from it and close one ticket. Now, I committed the rest and closed three tickets. If you have doubts, fine, put testcase into tracker and assign the ticket to me. But you must have something more than just uneasy feelings for that. > But as usual, you don't care. I'm not immortal you know... > This is the second time you commit something without agreement. You > either follow the discipline or get your write permissions revoked, as > simple as that. Is it too hard to understand? If you forgot, two years ago you, Vlad and I agreed that I will do cleanup and refactoring of savepoints. You can search the discussion on sql.ru. Two months ago we agreed that improved hash function is good. I'm going to commit that as well. A week ago we agreed that isc_random is evil. Do you need more agreements? Fine, I'll start more discussions. But silence is counted as a agreement, right?.. -- WBR, SD. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel
