03.03.2016 00:11, Dimitry Sibiryakov wrote: > This patch was sent to you for review two years ago. Yes, two years. > Exactly one year ago you picked couple of pieces from it and close one ticket. > Now, I committed the rest and closed three tickets.
I prefer one ticket resolved safely to three tickets resolved with doubts. > If you forgot, two years ago you, Vlad and I agreed that I will do cleanup and > refactoring of savepoints. You can search the discussion on sql.ru. Cleanup/refactoring is not expected to introduce changes in behavior. > Two months ago we agreed that improved hash function is good. I'm going to > commit that > as well. Again, without approval. Because you haven't provided the complete patch. > A week ago we agreed that isc_random is evil. No objections here, you were allowed to do that. > silence is counted as a agreement, right? No, it's not. Dmitry ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel