On Jun 29, 4:47 pm, John J Barton <[email protected]> wrote:
> On Jun 29, 2:09 am, "[email protected]"
> > - hitting ENTER after some autocompletion is shown *does not* accept
> > it, but removes it
> >   eg. enter "win", see "winDOW" autocompleted, hit ENTER, "win" is
> > chosen
>
> Yes, this is by design.  If ENTER accepts the completion, then users
> must explicit prevent completion before evaluation. Other users argue
> that explicit action should be required to accept the completion
> (currently right arrow or END key).

Ok, in my experience ENTER is the standard autocompletion key (eg.
IDEs like Eclipse) ;-) Don't want to argue about that, but ENTER has
one very big advantage over right arrow or END key (which is option
+page down on a mac, btw): you can hit it with 10-finger-typing. For
the others I have to move my hand, at least on a non-laptop keyboard,
which shouldn't be the goal of keyboard-based autocompletion ;-)

> > - hitting a dot "." (as described 
> > here:http://groups.google.com/group/firebug/browse_thread/thread/36a2e75bc...)
> >   when something is autocompleted *does not* select the current
> > selection;
> >   eg. enter "win", see "winDOW" autocompleted, hit ".", "win" is
> > chosen; would have expected "window." + next autocompletion
>
> Also by design. The thread you reference explains the problems with
> completion based on using implicit action to accept the completion.

Ah, I misunderstood the "1) Accept the completion." part then, which
talks about the dot. I think it would be cool to allow the dot (in
addition to ENTER ;-))

Also, I am confused by your comment from the thread:

"The case that really annoys me are  ones like:
   document.childNodes.l
(ending letter ell). The completion is "length", and my brain want
"enter" to cause document.childNodes.length to be evaluated, but
instead of the number two I get "undefined" because the enter key
causes the "ength" to be erased and the evaluated expression is
"document.childNodes.l"

This is my first point, right? Shouldn't we agree, then?

> > - the popup showing the current available variants does not highlight
> > the current selection,
> >   making it hard to follow the position in the list when TABbing
> > through it
>
> Ok I can fix this.

Cool.

> > - I would expect using up/down arrow keys change the variant when the
> > popup is shown
> >   (but instead they go through the command line history instead)
>
> TAB moves between choices as it does in other editors in Firebug.  UP/
> DOWN arrows remain as they have been in past versions.

Couldn't they just be active if no autocompletion is "active", ie.
when the field is empty? If I am inside autocompletion and suddenly
want to go to the history, I would "end" the autocompletion anyway and
then start to go through the list. Jumping straight from
autocompletion to history scanning is not a real use case I think.

And the popup doesn't go away then, btw.

> > - when the mouse is over the popup (by accident), it will always
> > select the item beneath it,
> >   even without clicking or moving the mouse; TAB doesn't work in this
> > case
>
> Ok thanks! That is a bug.
>
> Most of your comments above compare the current autocompletion to the
> one in 1.6a13 or a14. Please tell us what you liked about the 1.5.4
> completion over the 1.6a15 version. That would help a lot!

It didn't do unexpected things for me ;-) No, I think showing the list
of variants is a good thing, once the keys are following my
established neuronal wiring :-D

> The popup is not useless for me: it shows the possible choices so I
> can TAB through to get to them or type keys. You don't have to use a
> mouse and in fact I did not even implement the mouse part at first. I
> expect that the common pattern by experienced users will be to simply
> type the next character to select the completion. For example,
> window.d
> gives 6 completions, so I type letter 'o' then right arrow to accept
> it.
>
> Thanks for your comments, very helpful.

You're welcome.

Regards,
Alex

-- 
You received this message because you are subscribed to the Google Groups 
"Firebug" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/firebug?hl=en.

Reply via email to