As a general rule we don't actually do any JS validation... FWIW, when from time to time I need it, I generally use JSHint with /*jshint esnext:true, es5:true, curly:false */ /*global Firebug:true, FBTrace:true, Components:true, define:true */ or suchlike, and locally commit the validation fixes I need to make.
Simon Den måndagen den 31:e december 2012 kl. 07:11:41 UTC+1 skrev Rob Roy: > > Sebastian, > > I suspected that it may be JSDT problems in Eclipse. The reason for my > inquiry was the inconsistency of the validation; one file is fine while the > next has a large number of errors (see the file at > https://dl.dropbox.com/u/17169028/CommonJSDefineEclipseErrors.docx). > > So what tool does the FB team use for JS code validation? I tried JSLint > and JSHint and there were still many errors found on a test file. Is there > a recommended development and testing configuration? > > Thank you for your guidance. > > Rob > > On Saturday, December 29, 2012 4:09:30 AM UTC-5, Sebastian Zartner wrote: >> >> Btw. here's a list of issue reports related to the JSDT validation: >> >> >> https://bugs.eclipse.org/bugs/buglist.cgi?query_format=specific&order=relevance+desc&bug_status=__open__&product=JSDT&content=[validation] >> >> Sebastian >> >> On Saturday, December 29, 2012 9:55:26 AM UTC+1, Sebastian Zartner wrote: >>> >>> Ah, you want to have a look at Firebug's code. >>> I'm also using Eclipse when working on Firebug, though I don't give much >>> attention to the errors reported by JSDT. Most of the reports are just >>> wrong. E.g. it says there are three errors at line 399 of >>> /Firebug/extension/content/firebug/lib/url.js<https://github.com/firebug/firebug/blob/5fc314916ada97112911790e56bfffe0cd09051f/extension/content/firebug/lib/url.js#L399> >>> : >>> >>> - Syntax error on token "Invalid Character", delete this token >>> - Syntax error on token "(", ArrayLiteralHeader expected >>> - Syntax error on token "]", delete this token >>> >>> while the line is totally correct. >>> Also the third supposed syntax error is even not listed inside the * >>> Problems* view. >>> Regarding your example with "define([...], function(...) {...});" (for >>> which you didn't upload the screenshots btw.) it says "The left-hand >>> side of an assignment must be a variable", which is also wrong because >>> it's not an assignment but a function call. >>> So that feature of JSDT is obviously totally buggy. >>> >>> Anyway, if you want to work on Firebug and provide patches or write an >>> extension for it, you're very welcome. >>> Happy New Year! >>> >>> Sebastian >>> >>> On Friday, December 28, 2012 8:05:02 PM UTC+1, Rob Roy wrote: >>>> >>>> I've downloaded Firebug Lite and it loads the single firebug-lite.js >>>> file into Eclipse with only warnings, however, I'm running FB 1.11.1 in >>>> Firefox and am most familiar with that UI. My preference is to work with >>>> FB Extension for FF. >>>> >>>> On Friday, December 28, 2012 1:51:59 PM UTC-5, Rob Roy wrote: >>>>> >>>>> I've loaded Firebug extension for Firefox into Eclipse to examine the >>>>> code to better understand how FB works. When loading into Eclipse, there >>>>> are numerous JS language validation errors as described below. Since >>>>> Eclipse's JSDT is the gold standard for JS development, I wanted to see >>>>> if >>>>> others had the same problem and if they did, what corrective action(s) >>>>> could be recommended. Is there a recommended development environment for >>>>> FB? I would think that many others are using Eclipse and have also tried >>>>> to load the FB code. >>>>> >>>>> On Friday, December 28, 2012 6:31:43 AM UTC-5, Sebastian Zartner wrote: >>>>>> >>>>>> Are you talking about Firebug <https://getfirebug.com/whatisfirebug>or >>>>>> Firebug >>>>>> Lite <https://getfirebug.com/firebuglite>? Note that Firebug is a >>>>>> Firefox extension. >>>>>> Also I'm not sure what you want to do exactly. Do you want to >>>>>> integrate it into your website or somehow into Eclipse? >>>>>> You can try the small Firebug Lite download from this thread: >>>>>> >>>>>> https://groups.google.com/d/msg/firebug/dSMLzLcoxpc/rqwNRVuYbGMJ >>>>>> >>>>>> Sebastian >>>>>> >>>>>> On Thursday, December 27, 2012 5:18:55 PM UTC+1, Rob Roy wrote: >>>>>>> >>>>>>> I realize this is a very old post that I'm responding to, however, >>>>>>> I'm also have the same problems when loading the full FireBug .ZIP file >>>>>>> into an Eclipse project. Here are the specific details. >>>>>>> >>>>>>> I recently downloaded the latest .ZIP of the Firefox compatible >>>>>>> FireBug code and created an Eclipse project from this code. I'm running: >>>>>>> >>>>>>> Eclipse Java EE IDE for Web Developers. >>>>>>> >>>>>>> Version: Juno Service Release 1 >>>>>>> Build id: 20120920-0800 >>>>>>> >>>>>>> Java: JRE7 >>>>>>> >>>>>>> The javascript precompiler is throwing many errors on the CommonJS >>>>>>> AMD-style of "define([...], function(...) {...});" (see the uploaded >>>>>>> screen >>>>>>> shots). Many of the files don't have errors, but about 50 of the files >>>>>>> using this syntax are throwing errors and I can not identify any >>>>>>> differences or fixes to correct these errors. I prefer to use Eclipse >>>>>>> for >>>>>>> Javascript development due to these kinds of tools, but, given that the >>>>>>> FireBug source has gone through extensive testing, could this be an >>>>>>> error >>>>>>> in the JSDT precompiler (or syntax validator)? >>>>>>> >>>>>>> The compilation error is "The left-hand side of an assignment must >>>>>>> be a variable". >>>>>>> >>>>>>> This is just one of many types of errors that I'm finding. >>>>>>> >>>>>>> On Thursday, September 11, 2008 2:00:10 AM UTC-4, Robert Mark Bram >>>>>>> wrote: >>>>>>>> >>>>>>>> Hi All, >>>>>>>> >>>>>>>> I am using Eclipse 3.4 (Ganymeded) which has Javascript tooling in >>>>>>>> it >>>>>>>> (JSDT). When I make a Javascript project and put the Firebug Lite >>>>>>>> tools in it (firebug-lite.js and pi.js) around 200 errors come up >>>>>>>> for >>>>>>>> these two files. Has anyone tried this before? Is there some other >>>>>>>> setup I need to do? >>>>>>>> >>>>>>>> Thanks for any assistance! >>>>>>>> >>>>>>>> Rob >>>>>>>> :) >>>>>>> >>>>>>> -- You received this message because you are subscribed to the Google Groups "Firebug" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at https://groups.google.com/forum/#!forum/firebug
