Hi Honza, added a sample code how things could work from a api-consumer perspective. https://code.google.com/p/fbug/issues/detail?id=7452
Should we move the discussion into the issue, or do you think its worth also using the maillinglist? Thanks, Markus Am Freitag, 9. Mai 2014 11:41:55 UTC+2 schrieb Jan Honza Odvarko: > > On Thursday, May 8, 2014 5:01:36 PM UTC+2, Markus Staab wrote: >> >> with end-to-end I mean a testcase where also the server-side is >> implemented. >> > Yep, I believe this would be useful. Note that Firebug test use PHP for > the server side logic. > > >> >> > In any case we need to ensure backward compatibility (so, e.g. we can >> check the type of the argument passed in and if it's a Date() then execute >> the new logic) >> >> we will need a label nevertheless, so we should introduce a second >> optional date parameter.. no need for type-checking of the arguments. >> > OK, make sense, let's do it this way. > > Honza > > >> >> Markus >> >> >> 2014-05-08 16:49 GMT+02:00 Jan Honza Odvarko <[email protected]<javascript:> >> >: >> >>> On Thursday, May 8, 2014 4:23:12 PM UTC+2, Markus Staab wrote: >>>> >>>> I created a testcase in the linked issue. >>>> >>>> In case we add this new signature for console.timeStamp() we don't need >>>> a end to end test, do we? >>>> >>> What do you mean by end-to-end test? >>> >>> In any case we need to ensure backward compatibility (so, e.g. we can >>> check the type of the argument passed in and if it's a Date() then execute >>> the new logic) >>> >>> Honza >>> >>> >>>> >>>> >>>> 2014-05-08 14:56 GMT+02:00 Jan Honza Odvarko <[email protected]<javascript:> >>>> >: >>>> >>>>> >>>>> >>>>> On Thursday, May 8, 2014 12:42:04 PM UTC+2, Markus Staab wrote: >>>>>> >>>>>> Hi Honza! >>>>>> >>>>>> >>>>>>> I can suggest a patch related to the console.timeStamp API >>>>>>> >>>>>>> >>>>>>> >>>>>> please cross post the bugticket from mozilla regarding to a possible >>>>>> api change/addition >>>>>> >>>>> There is no existing bugzilla report. >>>>> >>>>> What I have in mind is: >>>>> >>>>> 1) Let's first have a test case (+ the server side that sends some >>>>> timing info) >>>>> 2) Modify Firebug's console.timeStamp() and see how the entire >>>>> scenario works >>>>> 3) If all work well, talk to other devtoolers and suggest the console >>>>> API change >>>>> >>>>> Honza >>>>> >>>>> >>>>>> Thanks, >>>>>> Markus >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to a topic in the >>>>> Google Groups "Firebug" group. >>>>> To unsubscribe from this topic, visit https://groups.google.com/d/ >>>>> topic/firebug/5hEUeaKYzNc/unsubscribe. >>>>> To unsubscribe from this group and all its topics, send an email to >>>>> [email protected] <javascript:>. >>>>> To post to this group, send email to [email protected]<javascript:> >>>>> . >>>>> Visit this group at http://groups.google.com/group/firebug. >>>>> To view this discussion on the web visit https://groups.google.com/d/ >>>>> msgid/firebug/3ee70619-4e57-4639-998b-c5a3f50dc459%40googlegroups.com<https://groups.google.com/d/msgid/firebug/3ee70619-4e57-4639-998b-c5a3f50dc459%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "Firebug" group. >>> To unsubscribe from this topic, visit >>> https://groups.google.com/d/topic/firebug/5hEUeaKYzNc/unsubscribe. >>> To unsubscribe from this group and all its topics, send an email to >>> [email protected] <javascript:>. >>> To post to this group, send email to [email protected]<javascript:> >>> . >>> Visit this group at http://groups.google.com/group/firebug. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/firebug/16e7dc4f-9995-4d14-82d8-bb5d56c92949%40googlegroups.com<https://groups.google.com/d/msgid/firebug/16e7dc4f-9995-4d14-82d8-bb5d56c92949%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- You received this message because you are subscribed to the Google Groups "Firebug" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/firebug. To view this discussion on the web visit https://groups.google.com/d/msgid/firebug/287ded26-5414-48d4-8042-4ce7393d8fc8%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
