So, how do you think this should be generically fixed?
In my tree, I simply commented out the /dev/tty setting. But, I don't want
to break things for linux. And, I don't want to have conditional
compilations, if they can be avoided.
Should I abuse another environment variable? Even still, how should it
look?
#linux
set FISH_TERMINALS_WITH_TITLES "/dev/pts" "whatever screen uses"
#osx
set FISH_TERMINALS_WITH_TITLES "/dev/tty" "whatever screen uses"
Then the code can go through that and do the strnstr? I don't particularly
like adding more "special" environment variables either, but I like it
better than conditional compilation.
Thoughts?
-Dave
On Fri, Apr 2, 2010 at 2:18 AM, Isaac Dupree <[email protected]
> wrote:
> On 04/02/10 01:03, David Frascone wrote:
>
>> I'm not sure why it was limiting terminals with tty in the name -- that
>> seems REALLY restrictive to me. This diff fixes things for OS X, but I'm
>> sure I've broken something else.
>>
>
> On modern Linux, the virtual consoles (i.e. not inside X-windows; accessed
> as [ctrl-]alt-F1 thru F6) are typically /dev/tty[1-6]; the rest of the
> terminals (within X-terminals, 'screen', etc.) are /dev/pts/[1 - infinity]
>
> use 'tty' to find this out for the current shell.
>
> I imagine this is what the fish code is filtering for, and it makes some
> sense since the virtual consoles don't have a title-bar, but I'm not sure if
> anything actually breaks if you try to set the vc's title-bar. You could try
> it! Or just filter more intelligently to distinguish between the Mac and
> Linux device situations.
>
> -Isaac
>
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Fish-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fish-users
