I removed the dependence on htmlview in my help.fish.  On Gentoo,
htmlview is a dependency of fish so it always gets installed.  If no
$BROWSER was specified then htmlview would always be used if it existed
so on Gentoo systems it was always the default "browser".

There are several problems with htmlview: for example, it does not have
an up-to-date list of browsers and it makes the assumption that all
browsers exist in /usr/bin.  By using it as our default choice, it would
always be used if it exists which would cause our help function to fail
to find any browser that was not on the out-of-date list in htmlview.
Adding browsers to our list would be of no help.

Another problem in htmlview is that its test for whether we are in X or
not is less stringent than ours so it could pick a graphical browser
even when we think we are in text mode.

My solution was to just get rid of using htmlview entirely.  I'm raising
this as a separate issue because maybe there is some logic or reason for
using htmlview that I am unaware of.  Since it can pick either a text
browser or a graphical browser it made the help.fish code a little more
complicated.  If there is a good reason for using htmlview then I'd be
glad to add that extra code.

The "browsers" that got promoted to the front of the lists after
eliminating htmlview are: www-browser, and x-www-browser.  I'm not
familiar with these.  Are they being actively maintained?  They don't
cause a problem on my system because they don't exist and are therefore
just skipped.  The possible problem they pose is that if they exist on
a system but are outdated then they could prevent our help from working.


Peace, James

------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Fish-users mailing list
Fish-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fish-users

Reply via email to