On 25.01.2010 18:29, Sean Nelson wrote: > Complete the addition of Feature Bits for all Jedec based chips. > Add FEATURE_SHORT_RESET, FEATURE_LONG_RESET, and FEATURE_EITHER_RESET > rewrite jedec functions to use getaddrmask > > Signed-off-by: Sean Nelson <[email protected]> > > --- a/flashchips.c > +++ b/flashchips.c > @@ -58,40 +58,42 @@ struct flashchip flashchips[] = { > .vendor = "AMD", > .name = "Am29F010A/B", > .bustype = CHIP_BUSTYPE_PARALLEL, > .manufacture_id = AMD_ID, > .model_id = AM_29F010B, /* Same as Am29F010A */ > .total_size = 128, > .page_size = 16 * 1024, > - .tested = TEST_OK_PRW, > - .probe = probe_29f040b, > + .feature_bits = FEATURE_ADDR_2AA|FEATURE_EITHER_RESET, > + .tested = TEST_OK_PR, > + .probe = probe_jedec, > .probe_timing = TIMING_ZERO, >
Ummm... technically, the probe function changed (well, in practice the command sequence should be identical). Do we want to keep TEST_OK_PR if the probe function changed? Regards, Carl-Daniel -- Developer quote of the year: "We are juggling too many chainsaws and flaming arrows and tigers." _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
