On 25.03.2010 10:54, Michael Karcher wrote: > This finishes the it87spi autodetection stuff of r983. Also fixes > sorting of Gigabyte boards. > > Signed-off-by: Michael Karcher <[email protected]> >
Hm. IMHO we have too much cosmetic changes in that table. The only thing that happens is reordering, but AFAICS this won't affect output in any way. Does ordering into different (OK/boardenable/bad) groups even make sense? That stuff is bound to change anyway we fix/modify some boards, and the group info is stored in other arrays anyway. A similar question applies to the laptop/non-laptop distinction in that table. Your patch changes the code to match the comments again, so I don't have a valid code-based reason to reject your patch. Still, I think we should discuss the general ordering of that table before that file will get a hotbed of reodering moves. Acked-by: Carl-Daniel Hailfinger <[email protected]> Regards, Carl-Daniel -- http://www.hailfinger.org/ _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
