On Fri, 26 Mar 2010, Carl-Daniel Hailfinger wrote: > On 24.03.2010 23:38, Idwer Vollering wrote: > > 2010/3/24 Carl-Daniel Hailfinger <[email protected]> > > > >> New version: Improve reliability of utsname detection. > >> > >> Add runtime and build environment info to the flashrom version message. > >> This patch uses code from Idwer Vollering and Maciej Pijanka. > >> I've added Makefile support and compiler version printing and > >> restructured the code heavily. > >> The code prints runtime system information and buildtime libpci > >> information (I couldn't find any runtime libpci version function). Due > >> to our ability to cross-compile flashrom, buildtime system information > >> from "uname -mrs" doesn't help diagnosing any problems. That's why only > >> libpci and gcc are buildtime info, and the rest is runtime info. > >> > >> Examples: > >> With PCI support: > >> flashrom v0.9.1-r971 on Linux 2.6.22.19-0.2-default (i686), built with > >> libpci 2.2.6, GCC 4.2.1 (SUSE Linux) > >> flashrom v0.9.1-r971 on Linux 2.6.22.19-0.2-default (i686), built with > >> libpci 2.2.6, LLVM 1/clang 1 > >> flashrom v0.9.1-r972 on Linux 2.6.27.29-0.1-default (x86_64), built with > >> libpci 3.0.1, GCC 4.3.2 [gcc-4_3-branch revision 141291] > >> > >> Without PCI support: > >> flashrom v0.9.1-r971 on Linux 2.6.22.19-0.2-default (i686), built with GCC > >> 4.2.1 (SUSE Linux) > >> flashrom v0.9.1-r971 on Linux 2.6.22.19-0.2-default (i686), built with LLVM > >> 1/clang 1 > >> flashrom v0.9.1-r972 on Linux 2.6.27.29-0.1-default (x86_64), built with > >> GCC 4.3.2 [gcc-4_3-branch revision 141291] > >> > >> Reviews appreciated, especially about the compiler part. I think this > >> can be valuable (e.g. if someone compiles with clang and triggers the > >> clang/flashrom miscompile), but I'm unsure if/how this works on Windows > >> and DOS. I tried to make it non-explosive, but... > >> > >> > >> Output from "flashrom --version" for non-Linux platforms and unusual > >> compilers would be appreciated. > >> > > > > flashrom v0.9.1-r973 on CYGWIN_NT-5.1 1.7.1(0.218/5/3) (i686), built with > > GCC 4.3.4 20090804 (release) 1 > > > > flashrom v0.9.1-r973 on FreeBSD 8.0-RELEASE-p2 (i386), built with libpci > > 3.1.7, GCC 4.2.1 20070719 [FreeBSD] > > > > > >> Signed-off-by: Carl-Daniel Hailfinger <[email protected]> > >> > > > > Signed-off-by: Idwer Vollering <[email protected]> > > > > > > Anyone up for an ack?
Looks fine for me Acked-by: Maciej Pijanka <[email protected]> > > Regards, > Carl-Daniel > -- Maciej Pijanka I don't fear computers, I fear lack of them -- Isaac Asimov _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
