On Sat, Oct 30, 2010 at 12:43 AM, Paul Menzel < [email protected]> wrote:
> Am Samstag, den 30.10.2010, 02:16 +0200 schrieb Carl-Daniel Hailfinger: > > Use mktemp unconditionally for security reasons. > > Avoid non-portable seq. > > > > Signed-off-by: Carl-Daniel Hailfinger <[email protected] > > > > > > Index: > flashrom-torturescript_portability/util/flashrom_partial_write_test.sh > > =================================================================== > > --- > flashrom-torturescript_portability/util/flashrom_partial_write_test.sh > (Revision 1219) > > +++ > flashrom-torturescript_portability/util/flashrom_partial_write_test.sh > (Arbeitskopie) > > @@ -34,8 +34,12 @@ > > echo "testing flashrom binary: ${FLASHROM}" > > > > OLDDIR=$(pwd) > > -if [ -z "$TMPDIR" ]; then > > - TMPDIR=$(mktemp -d) # test data location > > + > > +# test data location > > +TMPDIR=$(mktemp -d -t flashrom_test.XXXXXXXXXX) > > +if [ "$?" != "0" ] ; then > > + echo "Could not create temporary directory" > > Full stop at the end. > > Is `mktemp` always installed? If not will there be an error message – > passed down from Bash – indicating that it needs to be installed? > No... it will simply tell the user "Could not create temporary directory." How about we re-factor the mktemp check as such: # create location to store temporary data for test usage TMPDIR=$(mktemp -d -t flashrom_test.XXXXXXXXXX) if [ "$?" != "0" ] ; then echo "Could not create temporary directory" which mktemp > /dev/null if [ "$?" != "0" ] ; then echo "mktemp not found" fi exit $EXIT_FAILURE fi > > > + exit $EXIT_FAILURE > > fi > > > > ZERO_4K="00_4k.bin" > > @@ -65,8 +69,10 @@ > > > > # Make 4k worth of 0xff bytes > > echo "begin 640 $FF_4K" > "$FF_4K_TEXT" > > -for i in `seq 0 90` ; do > > +i=0 > > +while [ $i -le 90 ] ; do > > echo > "M____________________________________________________________" >> > "$FF_4K_TEXT" > > + i=$((${i} + 1)) > > done > > echo "!_P``" >> "$FF_4K_TEXT" > > echo "\`" >> "$FF_4K_TEXT" > > > Thanks, > > Paul > > _______________________________________________ > flashrom mailing list > [email protected] > http://www.flashrom.org/mailman/listinfo/flashrom > -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.
_______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
