On Mon, Nov 1, 2010 at 3:30 PM, Idwer Vollering <[email protected]> wrote:
> 2010/11/1 David Hendricks <[email protected]> > > On Sat, Oct 30, 2010 at 12:43 AM, Paul Menzel < >> [email protected]> wrote: >> >>> Am Samstag, den 30.10.2010, 02:16 +0200 schrieb Carl-Daniel Hailfinger: >>> > Use mktemp unconditionally for security reasons. >>> > Avoid non-portable seq. >>> > >>> > Signed-off-by: Carl-Daniel Hailfinger < >>> [email protected]> >>> >> > Acked-by: Idwer Vollering <[email protected]> > > >> > >>> > Index: >>> flashrom-torturescript_portability/util/flashrom_partial_write_test.sh >>> > =================================================================== >>> > --- >>> flashrom-torturescript_portability/util/flashrom_partial_write_test.sh >>> (Revision 1219) >>> > +++ >>> flashrom-torturescript_portability/util/flashrom_partial_write_test.sh >>> (Arbeitskopie) >>> > @@ -34,8 +34,12 @@ >>> > echo "testing flashrom binary: ${FLASHROM}" >>> > >>> > OLDDIR=$(pwd) >>> > -if [ -z "$TMPDIR" ]; then >>> > - TMPDIR=$(mktemp -d) # test data location >>> > + >>> > +# test data location >>> > +TMPDIR=$(mktemp -d -t flashrom_test.XXXXXXXXXX) >>> > +if [ "$?" != "0" ] ; then >>> > + echo "Could not create temporary directory" >>> >>> Full stop at the end. >>> >>> Is `mktemp` always installed? If not will there be an error message – >>> passed down from Bash – indicating that it needs to be installed? >>> >> > It is safe to assume it is. > To elaborate, "mktemp" is part of the GNU coreutils package, which is pretty much mandatory on GNU/Linux distros: Ubuntu example: dhend...@amd870:~$ dpkg -S `which mktemp` coreutils: /bin/mktemp Gentoo example: (cros-chroot) dhend...@thegates ~ $ equery belongs `which mktemp` * Searching for /usr/bin/mktemp ... sys-apps/coreutils-7.5-r1 (/bin/mktemp) sys-apps/coreutils-7.5-r1 (/usr/bin/mktemp -> /bin/mktemp) -- David Hendricks (dhendrix) Systems Software Engineer, Google Inc.
_______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
