On Mon, 30 May 2011 11:59:57 -0400 Steven Zakulec <[email protected]> wrote:
> Hi, this is the latest version of the patch, taking into account Peter's > request to me to change the struct to uint16_t and the values to milliwatts. > Signed-off-by: Steven Zakulec <[email protected]> hello steven (what a nice name! ;) your patch does not compile: flashchips.c:1335: error: expected expression before ‘,’ token flashchips.c:1373: error: expected expression before ‘,’ token if you look at it, it is quite obvious ;) probably some copy & paste mistake or regex going berserk. since you have to revise it anyway i have a few nitpicking comments and two important notes to make: > Index: flash.h > =================================================================== > --- flash.h (revision 1322) > +++ flash.h (working copy) > @@ -145,6 +145,10 @@ > int (*unlock) (struct flashchip *flash); > int (*write) (struct flashchip *flash, uint8_t *buf, int start, int > len); > int (*read) (struct flashchip *flash, uint8_t *buf, int start, int len); > + struct { > + uint16_t min; > + uint16_t max; > + }voltage; }<space>voltage; is our usual style afaics > Index: flashchips.c > =================================================================== > --- flashchips.c (revision 1322) > +++ flashchips.c (working copy) > @@ -54,6 +54,7 @@ > * .unlock = Chip unlock function > * .write = Chip write function > * .read = Chip read function > + * .voltage = Voltage min and max range in decivolt this is no longer correct. > { > @@ -3285,6 +3379,7 @@ > }, > .write = write_m29f400bt, > .read = read_memmapped, > + .voltage = {4750, 5250}, /*5.0V +-5% for -55 model, > +-10% for rest */ <space> after /* > { > @@ -3483,6 +3583,7 @@ > }, > .write = write_82802ab, > .read = read_memmapped, > + .voltage = {4500, 5500}, /*5.0V +-10% read, 12V fast > program & erase- +-5% standard, +-10% option */ > }, <space> after /* > { > @@ -6653,6 +6841,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {4500, 5500}, /* Datasheet says some are only > 4.75-5.25 V */ > }, i havent looked at the datasheet, but if so then we should use the tightest range i.e. 4750, 5250 imho. > { > @@ -6684,6 +6873,7 @@ > }, > .write = write_jedec_1, > .read = read_memmapped, > + .voltage = {4500, 5500}, /* Datasheet says some are only > 4.75-5.25 V */ > }, same looks good to me otherwise, thanks a lot! i have not checked the datasheets or the spreadsheet you made though.</decline of responsibility> ;) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
