On Sat, 4 Jun 2011 00:40:17 +0200 Peter Stuge <[email protected]> wrote:
> Carl-Daniel Hailfinger wrote: > > I had asked Steven to use decivolt precision to avoid wasting lots of > > space. > > Oh dear. > > > > Did some magic chips appear which require millivolt precision? > > One chip specs voltage with .05 V precision. It's a good idea to use > SI standard units. It's a bad idea to use anything else. uint_16t > also fits well for the so far only user of this information; the USB > flashing protocol Stefan and I have worked on. deci IS an SI prefix, as well as centi, deca and hecto (i.e. 10^+/-1, 10^+/-2), but i have to agree with peter: it does not make a lot of sense to be that petty on (constant/text segment) space usage imho. if that information is deemed too big, then it should not be in there at all. where/when do you think it gets in the way of using flashrom? we could use a macro similar to the ones used for hiding certain board information triggered by CONFIG_PRINT_WIKI in print.c for flashchips.c this could actually be a good idea, because we could then create different macros for different bus types and ensure that all important fields for that bustype are initialised. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
