On 2011.06.10 19:21, Stefan Tauner wrote:
in the table above all programmers are marked ok although they were not
all tested...
i am quoting my last mail: "please add them and just mark them as NT in
the array".
Ah, sorry, I completely overlooked that one. Thanks for the reminder.
i also do not recognize the reason to order the devices like that
Well, first from Olimex came the ARM-USB-OCD (PID 3), then came the
ARM-USB-TINY (PID 4), so that's our start. But then when the H versions
came along, Olimex curiously "released" the OCD-H (PID 2B) after the
TINY-H (PID 2A). It only felt more natural to me to have both the H and
non H versions listed in the same order in the source, but if you want
to reorganize them around as you see fit, just go ahead.
regarding the man page patch:
-can be any of
+can be one of
how is that better (non-native speaker here...)?
Non native speaker either, but I think (feel) "any of" is better applied
to very short lists, whereas "one of" is better applied to long ones,
and our list has grown long. As the matter above, just a matter of
individual perception.
>> Please note that the External_flashers/programmers section of the
>> Supported_hardware wiki [2] should probably also be updated to only
>> mention FT2232/FT4232 (without the H), as we now have evidence that
>> FT2232D/FT2232L are working just as well for SPI access.
why not drop the 'H' altogether? or list the other versions there too
(like in "FT2232D/H/L" or similar)?
Considering that I have just found out that there also exists HL and HQ
versions of the above chips, I think it's safer to go without the suffix
there, so I amended the man page.
if you resubmit the patches, could you please merge them?
Here you go. Signed-off-by: Pete Batard <pbatard at gmail.com>
Regards,
/Pete
Index: flashrom.8
===================================================================
--- flashrom.8 (revision 1325)
+++ flashrom.8 (working copy)
@@ -183,7 +183,7 @@
.BR "* it87spi" " (for flash ROMs behind an ITE IT87xx Super I/O LPC/SPI \
translation unit)"
.sp
-.BR "* ft2232_spi" " (for SPI flash ROMs attached to a FT2232H/FT4232H/JTAGkey
\
+.BR "* ft2232_spi" " (for SPI flash ROMs attached to an FT2232 or FT4232 \
based USB SPI programmer)"
.sp
.BR "* serprog" " (for flash ROMs attached to a programmer speaking serprog)"
@@ -361,8 +361,9 @@
.sp
syntax where
.B model
-can be any of
-.BR 2232H ", " JTAGkey ", or " 4232H
+can be one of
+.BR 2232H ", " 4232H ", " jtagkey ", " openmoko ", " arm-usb-tiny ", " \
+arm-usb-tiny-h ", " arm-usb-ocd " or " arm-usb-ocd-h
and
.B interface
can be any of
Index: ft2232_spi.c
===================================================================
--- ft2232_spi.c (revision 1325)
+++ ft2232_spi.c (working copy)
@@ -38,6 +38,12 @@
#define FIC_VID 0x1457
#define OPENMOKO_DBGBOARD_PID 0x5118
+#define OLIMEX_VID 0x15BA
+#define OLIMEX_ARM_OCD_PID 0x0003
+#define OLIMEX_ARM_TINY_PID 0x0004
+#define OLIMEX_ARM_OCD_H_PID 0x002B
+#define OLIMEX_ARM_TINY_H_PID 0x002A
+
const struct usbdev_status devs_ft2232spi[] = {
{FTDI_VID, FTDI_FT2232H_PID, OK, "FTDI", "FT2232H"},
{FTDI_VID, FTDI_FT4232H_PID, OK, "FTDI", "FT4232H"},
@@ -45,6 +51,10 @@
{FIC_VID, OPENMOKO_DBGBOARD_PID, OK,
"First International Computer, Inc.",
"OpenMoko Neo1973 Debug board (V2+)"},
+ {OLIMEX_VID, OLIMEX_ARM_OCD_PID, NT, "Olimex", "ARM-USB-OCD"},
+ {OLIMEX_VID, OLIMEX_ARM_TINY_PID, OK, "Olimex", "ARM-USB-TINY"},
+ {OLIMEX_VID, OLIMEX_ARM_OCD_H_PID, NT, "Olimex", "ARM-USB-OCD-H"},
+ {OLIMEX_VID, OLIMEX_ARM_TINY_H_PID, NT, "Olimex", "ARM-USB-TINY-H"},
{},
};
@@ -167,6 +177,22 @@
ft2232_vid = FIC_VID;
ft2232_type = OPENMOKO_DBGBOARD_PID;
ft2232_interface = INTERFACE_A;
+ } else if (!strcasecmp(arg, "arm-usb-ocd")) {
+ ft2232_vid = OLIMEX_VID;
+ ft2232_type = OLIMEX_ARM_OCD_PID;
+ ft2232_interface = INTERFACE_A;
+ } else if (!strcasecmp(arg, "arm-usb-tiny")) {
+ ft2232_vid = OLIMEX_VID;
+ ft2232_type = OLIMEX_ARM_TINY_PID;
+ ft2232_interface = INTERFACE_A;
+ } else if (!strcasecmp(arg, "arm-usb-ocd-h")) {
+ ft2232_vid = OLIMEX_VID;
+ ft2232_type = OLIMEX_ARM_OCD_H_PID;
+ ft2232_interface = INTERFACE_A;
+ } else if (!strcasecmp(arg, "arm-usb-tiny-h")) {
+ ft2232_vid = OLIMEX_VID;
+ ft2232_type = OLIMEX_ARM_TINY_H_PID;
+ ft2232_interface = INTERFACE_A;
} else {
msg_perr("Error: Invalid device type specified.\n");
free(arg);
_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom
