Am 24.12.2011 01:35 schrieb Stefan Tauner:
>  - rename from find_next_included_romentry to get_next_included_romentry
>  - return a pointer to a rom_entry instead of just its index
>
> Signed-off-by: Stefan Tauner <[email protected]>

The changelog only describes what you're doing, but not the reason why.
If you add a short statement about the reason (readability improvement,
whatever) to the changelog, and if you change
if (entry == NULL) {
to
if  (!entry) {
this is
Acked-by: Carl-Daniel Hailfinger <[email protected]>

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/


_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to