On Sun, 25 Dec 2011 01:17:24 +0100 Carl-Daniel Hailfinger <[email protected]> wrote:
> Hi Stefan, > > minor commit log nitpicks only. > > As first line of the changelog, use this instead for better > searchability of the changelog: > Add deferred --image processing > > Am 24.12.2011 01:35 schrieb Stefan Tauner: > > The general idea and most of the code is stolen from chromiumos: > > The general idea and most of the code are based on the following > commits in the chromiumos flashrom tree: > > > > > 8fc0740356ca15d02fb1c65ab43b10844f148c3b > > bb9049c66ca55e0dc621dd2c70b5d2cb6e5179bf > > Signed-off-by: Louis Yung-Chieh Lo <[email protected]> > > > > and the main part: > > d0ea9ed71e7f86bb8e8db2ca7c32a96de25343d8 > > Signed-off-by: David Hendricks <[email protected]> > > > > My implementation does not defer the processing until doit(), but after the > > s/My/This/ just out of interest: why? this was added to emphasize the difference to chromiumos. > > argument parsing loop only (doit() should not contain argument checks). > > > > This allows to specify -i and -l parameters in any order. > > > > Signed-off-by: Stefan Tauner <[email protected]> > > Acked-by: David Hendricks <[email protected]> > > You already have an ack, go ahead. thanks, committed in r1482 -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
