Hi Ocean,

On Mon, Mar 23, 2020 at 2:00 PM Ocean Huang via flashrom
<flashrom@flashrom.org> wrote:
>
> Hi David:
>
> For flashrom could update BIOS successfully on the Intel Bakerville 
> platform(CPU:SKY-D), we need to add device id to chipset_enables table in the 
> file of"chipset_enables.c", or it will cause below error:
> WARNING: No chipset found. Flash detection will most likely fail.
> No EEPROM/flash device found.
> Note: flashrom can never write if the flash chip isn't found automatically.
>
> So could you please help to add these three device ids to the chipset_enable 
> table and upload to the Github?
> Attached the changed file.

I see that you have added these three new device IDs:

    {0x8086, 0xa1c8, NT,  "Intel", "C620 Series Chipset Supersku",
enable_flash_c620},
    {0x8086, 0xa248, NT,  "Intel", "C620 Series Chipset Supersku",
enable_flash_c620},
    {0x8086, 0xa249, NT,  "Intel", "C620 Series Chipset Supersku",
enable_flash_c620},

I can confirm that the last two IDs are for Super SKUs, but "0xa1c8"
(the first one) seems to be a "QS/PRQ" SKU. Could you please confirm
it? I have created a change to add these IDs:

https://review.coreboot.org/39780

In addition, since flashrom can successfully update the BIOS on these
chipsets, knowing the Device IDs that have been tested would be much
appreciated. That way, we can mark the chipsets as tested.

> Thanks,
> Best Regards,
> Ocean
>
> --
> Thanks,
> Best Regards,
> Ocean Huang
> BIOS Engineer
> Celestica(Shanghai) R&D Center, China
> email: hah...@celestica.com
> www.celestica.com
> _______________________________________________
> flashrom mailing list -- flashrom@flashrom.org
> To unsubscribe send an email to flashrom-le...@flashrom.org

Thanks in advance,

Angel Pons
_______________________________________________
flashrom mailing list -- flashrom@flashrom.org
To unsubscribe send an email to flashrom-le...@flashrom.org

Reply via email to