Users should not be prevented from setting custom layouts on spark
controls as it removed flexibility from the framework. A good example
of this is Scroller.
Time and time again I've come across UI's that require increase and
decrease buttons only when paging or scrolling, and developers build
it over and over again. If we could set layouts on a Scroller we would
be able to use its built in functionality to take care of this for
use. I don't propose we add an InlineScroller component, but allow
uses to set layouts on the Scroller and add some new skins and an
InlineScrollerLayout.
As an example I've added the following to my whiteboard area
incubator/flex/whiteboard/tink/navigators/src/ws/tink/spark/controls/
InlineScroller.as
incubator/flex/whiteboard/tink/navigators/src/ws/tink/spark/layouts/
InlineScrollerLayout.as
incubator/flex/whiteboard/tink/navigators/src/ws/tink/spark/skins/
controls/HNoTrackNoThumbScrollBarSkin.mxml
incubator/flex/whiteboard/tink/navigators/src/ws/tink/spark/skins/
controls/InlineScrollerSkin.mxml
incubator/flex/whiteboard/tink/navigators/src/ws/tink/spark/skins/
controls/VNoTrackNoThumbScrollBarSkin.mxml
and source for examples here
incubator/flex/whiteboard/tink/navigators/examples/src/
InlineScrollerExamples.mxml
You can view a compiled example here
http://www.tink.ws/examples/apache-flex/InlineScrollerExamples.html
And an overview of other stuff in my whiteboard here (I should
probably add it to the wiki?).
http://www.tink.ws/examples/apache-flex/
Tink
On 8 Mar 2012, at 22:41, Justin Mclean wrote:
Hi,
I had not realized the templates had not been donated in the first
dump.
One concern I have is that they use SWFObject so there is an external
dependency there.
SWFObject is MIT (Category A licence) so should be no issues there.
IMHO, you are making more work by mucking with the templates now,
but there
really isn't anything I can do to stop you.
More work for who? Me perhaps? I've not changed a single line of
code yet. I don't see it being any extra effort to come up with a
fix now and apply that after the code has been donated. Again we
are talking about changes to a single fairly simple HTML page.
We'll just have to remember to pay close attention to changes to
the template.
Totally agree. Any changes would have improve the template in some
way for the better and be fully tested on a wide set of browsers and
platforms. If anyone does submit a patch I'll help to get it
accepted but that doesn't mean I'm going to commit it straight to
the trunk. :-)
I would of assumed that the template wold of been part of the
upcoming compiler donation as it's used as part of the compilation
process.
Thanks,
Justin
