Bertrand, Om, Before I leave for the weekend, I've taken care of (at least, I hope I did):
> 1) IMO the mention of the as3corelib stuff in NOTICE is not required - > it's license is in LICENCE, that's fine. I've removed this from NOTICE. > 2) The LICENCE file contains extra stuff (like > frameworks/src/mx/effect/easing for example) that should be removed. I've removed this from LICENCE. > 3) What's ./src/assets/fonts/open-sans/Apache License Version 2.txt ? > If the font files in there are Apache licensed that should be > mentioned in LICENCE. I've removed the .txt from the project and referenced the licence for the font in LICENCE. > 4) apache-flex-sdk-installer-1.0.0-incubating-src.tar.gz contains > (Eclipse I assume) .project and other similar files, do they really > belong in there? We don't usually release such files. Om, you're in charge of the source packages... > 5) build.properties contains things like > installer.url.win=http://people.apache.org/~bigosmallm/installapacheflex/InstallApacheFlex.exe > is that what you want? If people are meant to put their own settings > in that build.properties file I'd recommend using example.com or other > URLs that don't point to apache.org. I'm not sure if these are actually needed, or if they can be removed altogether. Om? > 6) in build.properties, KEYSTORE=installapacheflex_self.p12 - has the > signing process for that file been solved? Do we have a jira issue > that explains how that's handled? I've create FLEX-33186 [1]. > 9) IIUC the goal of the installer is for Flex users to download the > Apache Flex SDK - if yes that needs to happen via mirrors to avoid > hitting apache.org directly. I haven't followed the details but it > seems like the installer is indeed using mirrors - do we have docs or > a jira issue that explains how that works? I'd like to review that > before the installer is out in the wild. I've create FLEX-33187 [2]. All other points I leave to Om :-) EdB 1: https://issues.apache.org/jira/browse/FLEX-33186 2: https://issues.apache.org/jira/browse/FLEX-33187 -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
