Yeah, we want SVN patches. They're supposedly easier to manage. I assume there isn't much to this fix so we can probably work from the diff.
________________________________ From: flexcoders@yahoogroups.com [mailto:[EMAIL PROTECTED] On Behalf Of Josh McDonald Sent: Friday, June 27, 2008 7:16 AM To: flexcoders@yahoogroups.com Subject: Re: [flexcoders] RadioButton change event not firing in Flex 3 when button in group is deselected Not using eclipse' SVN, I hate it :) I went with regular old diff. I can always re-submit it again some time, but I'm not recompiling the whole source since that'd take weeks (exaggerating only a little), Flex's compiler ain't quick. I'm just monkey-patching changes into my test-project source tree. On Sat, Jun 28, 2008 at 12:07 AM, Jonathan Branam <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > wrote: You should use svn diff. I usually do it from within Eclipse. It has a command called "Create a Patch" or something. But I think just: svn diff > patch.txt will work. On Fri, Jun 27, 2008 at 1:22 AM, Josh McDonald <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > wrote: The problem's in RadioButtonGroup, I've posted the details to the bug. Alex, I've got Contrib permission, but the "submit a patch" document just talks about TortoiseSVN. Is the patch file I need to submit simply: diff /path/to/checkout/foo.as /path/to/new/foo.as > mypatch.diff Just using standard BSD Diff (OS X)? Or have I got the operands in the wrong order, or is it not standard diff at all? -Josh RadioButton.click simply calls out to group.selection On Fri, Jun 27, 2008 at 2:31 PM, Alex Harui <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > wrote: It looks like it was done to prevent events for programmatic changes to .selected which would be correct, but the RBG programmatically unselects an RB and this code now prevents an event which probably should fire. ________________________________ From: flexcoders@yahoogroups.com <mailto:flexcoders@yahoogroups.com> [mailto:flexcoders@yahoogroups.com <mailto:flexcoders@yahoogroups.com> ] On Behalf Of Josh McDonald Sent: Thursday, June 26, 2008 3:44 PM To: flexcoders@yahoogroups.com <mailto:flexcoders@yahoogroups.com> Subject: Re: [flexcoders] RadioButton change event not firing in Flex 3 when button in group is deselected It makes more sense to me to be for Radiobutton than Checkbox. Why on earth would you not want to get a change event when a checkbox is unchecked? -Josh On Fri, Jun 27, 2008 at 2:48 AM, Samuel Neff <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > wrote: Thanks for confirming. Bug filed. https://bugs.adobe.com/jira/browse/SDK-15918 <https://bugs.adobe.com/jira/browse/SDK-15918> Best regards, Sam ----------------------------------------------------------------- We're Hiring! Seeking passionate Flex, C#, or C++ (RTSP, H264) developer in the Washington D.C. Contact [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> On Thu, Jun 26, 2008 at 11:51 AM, Alex Harui <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> > wrote: That's what I figured, just wanted to confirm. I still think the change (which was for CheckBox) had unintended consequences in RadioButton, so file a bug. __._,_ -- "Therefore, send not to know For whom the bell tolls. It tolls for thee." :: Josh 'G-Funk' McDonald :: 0437 221 380 :: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> -- "Therefore, send not to know For whom the bell tolls. It tolls for thee." :: Josh 'G-Funk' McDonald :: 0437 221 380 :: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> -- "Therefore, send not to know For whom the bell tolls. It tolls for thee." :: Josh 'G-Funk' McDonald :: 0437 221 380 :: [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
