Comments on this patch:
1) Edits to flexwiki.config should actually be made to
flexwiki.config.template. To allow developers to mess around with the
.config files on their machines but still maintain a "clean" copy that goes
in the distribution zip, during the build we throw away the .config files
and use the .config.template files instead.
2) In the great religious debate between whether braces are required
for single-line blocks.they are. J Minor point.
3) ShowEditPageZ is a pretty ambiguous name I know I had no idea what
it did without reading the code body. A name like ShowEditPageFinal (or
similar) would be much better.
4) Methods should be sorted alphabetically within a protection level.
5) You're slurping the whole file into memory before writing it out.
While I'm no fan of premature optimization, this does seem like a good
vector for a DoS attack. Then again, it's no different than the wikitext we
let people post.
6) You're using string concatenation to put path names together
(ReturnDirectoryToWriteTo). Use Path.Combine instead.
7) What's the purpose of putting different file types in different
directories? Is it just to organize things on the server, i.e. convenience?
8) You really limit the system to nine versions of a file? Is there a
reason for that?
9) On my machine, when I click "Show Attachment Controls", the right
border slides off the screen, making me scroll. That's a bit inconvenient.
10) When I tried to upload an image, I got a server error "The connection
was reset". The error is super cryptic and I haven't had a chance to dig
into what's causing it.
11) Along the same lines, I'd like to see a switch in FlexWiki.config that
lets me turn off this feature entirely. I can see some administrators being
unwilling to deploy it given the liability issues that could ensue by giving
people a place to post arbitrary files. It can default to on, but we should
be able to switch it off.
12) The "Send" and "Create Attachment" buttons are confusing to me - it
seems like "Create Attachment" inserts WikiTalk, but it's not clear - both
buttons imply "upload" to me.
Because I was unable to get it working, I couldn't do much more review than
that. Do you have the feature working on a webserver somewhere in its
current form? I'd love to hear what other people think of it, too.
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of John
Davidson
Sent: Monday, July 16, 2007 5:56 PM
To: FlexWiki Users Mailing List
Subject: Re: [Flexwiki-users] Upload File & Attachment to Topic
This should manage all the various pecadillos of browser implementations in
a single, generic, method.
>From a technical point of view it all works, and even looks ok now, but it
could probably be improved in terms of how the WikiEdit page is generated. I
will tackle that later if the basic concept of attachments is accepted.
Now that I have reliable communications between the web page and the
back-end processes I could improve the locking in DocMan format, which is
currently all manual at this time. There is no automatic versioning, but I
would also consider it if there was a way to make it configurable, rather
than a single solution.
Hope this is more what you are looking for
John Davidson
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Flexwiki-users mailing list
Flexwiki-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flexwiki-users
