On 7/18/07, Craig Andera <[EMAIL PROTECTED]> wrote: > > > 7) What's the purpose of putting different file types in > > different > > > directories? Is it just to organize things on the server, i.e. > > convenience? > > > > That was the way the original upload code from the FlexWiki site did > > it so I kept it. This is available for discussion. There is no real > > reason in today's file systems. also if I was to make it possible to > > store the uploads in SQL Server it would all go in the same table. > > So this raises a two interesting questions, one important and one not: > > * (Not important) Is it necessary to match what's there with the original > upload code? I can't think of a good reason to, especially as the 1.8->2.0 > transition is our chance to introduce breaking changes (within reason). > However, others who are using this feature might have different opinions. > * (Important) Are attachments a feature of the web app or a feature of the > core? If they're a feature of the core, then we should probably support > storing attachments in whatever store has been defined - filesystem, SQL > Server, whatever else. That will require modification of the core components > (security, caching, etc.). If it's a feature of the web app, then it may be > incompatible or inconsistent with non-filesystem stores, but it'll be easier > to code. >
Here is where other FlexWiki users need to provide comment about structure and features. What has been provided is meant to show some of the potential capability for attachments. If we go back to the original discussion many months ago you were talking about a core integration, but it seemed like it would fall outside the scope you were willing to commit to. Therefore I suggested making it part of the web app, but did not clearly explain how and what you would get. > > > > > > > 9) On my machine, when I click "Show Attachment Controls", the > > right > > > border slides off the screen, making me scroll. That's a bit > > inconvenient. > > > > That happens in Firefox, at least 2.0.0.4. It does not happen in IE > > 7.0.5730.11. It is behaviour like this that drives web programmers > > nuts. I need more time to work out why it behaves this way or find a > > fix. I agree it is annoying (Note IE does not give any scrollbars and > > some of the controls will end up below the window, making it necessary > > to blindly navigate to these hidden controls by tabbing.) > > Well, from my perspective this is your call. That is, whether to release it > as-is or not is up to you. Personally I find it pretty annoying, but I'd > probably turn off attachments on my wikis anyway for other reasons. > This stems from a bug in IE not Firefox. The div for the save button groupings has a text-align style in it. IE processes this style while Firefox doesn't as the standard says not to use text-align in Firefox. Now that I know the cause I can determine a fix for both browsers. > As far as the question of rewriting WikiEdit.aspx, I'd do you one better and > suggest that the entire web app needs to be rewritten. It's a royal mess. > It's not presumption on your part to do so, but I do think it would be smart > of us to coordinate about timing. As we march (slowly but surely) towards > 2.0, branching towards a 2.2 release is an option we should consider. > I recommend that the functionality remain as part of the web app for now and be included in a rewrite of the web app. That way the requirement could be stabilized through use before it is integrated into the core, say 2.4 or 2.8. > > > > > > 12) The "Send" and "Create Attachment" buttons are confusing to me > > - it > > > seems like "Create Attachment" inserts WikiTalk, but it's not clear - > > both > > > buttons imply "upload" to me. > > > > > The Send button causes the file to be uploaded to the server. The > > Create Attachment emits the WikiTalk based on the input from the > > controls exposed by the chosen radio button for format. > > Ah, I see. Maybe a way of visually separating those two things (another > sidebar box?) would help make that clearer. Or maybe I'm just slow. :) > As I fix the quirks in the interface I will address that. > > > > > Because I was unable to get it working, I couldn't do much more > > review than > > > that. Do you have the feature working on a webserver somewhere in its > > > current form? I'd love to hear what other people think of it, too. > > > > > A working version is available at (this is one without any > > authentication controls): > > > > http://ods.dyndns.org/FlexWiki/default.aspx/OdsWiki/AttachmentPage.html > > Can you describe what you're doing for authentication? That's one of my > concerns: we've added a new namespace-based security model to FlexWiki, and > now we've given people the ability to upload content that's in no namespace. > Reconciling those two things seems like it might be difficult, but maybe > you've thought of something clever. Certainly it argues for integrating > "attachment" capability into the core. The authentication for the upload follows the authentication for the page. If an principalviewing a topic has the right to edit that topic then they would have the ability to upload (and link) a file from that topic. If they did not have edit rights they would not be able to upload. That is the current implementation. It would be possible to include a wiki-wide control based on _ContentBaseDefinition controls if that was desirable? > > I should also mention that I'm just asking questions, not saying how it > "needs" to be done. I'd like to see some discussion on this feature, and I > think we should strategize about what release it goes into, but I'm not > going to hold it up just because it isn't done how I pictured it. In other > words: comments from the community are needed - please let us know what you > want to see here! > Intelligent discourse is always welcome and encourage, never taken as criticsm. John Davidson ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Flexwiki-users mailing list Flexwiki-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flexwiki-users
