Notes on this patch: 

 

.         QualifiedTopicRevision contains an overload that lets you build up
an instance by local name and namespace - creating your own dotted name is
not necessary. 

.         You shouldn't assume that the definition topic name is
"_ContentBaseDefinition" - use NamespaceManager.DefinitionTopicName or
DefinitionTopicLocalName instead. 

 

I went ahead and made the extremely minor changes required to bring this
into line. 

 

The one thing I'd like to see here is that it would be nice if the warning
message would be "You do not have permission to create this topic" instead
of "You do not have permission to change this topic" when the topic is being
created rather than edited. 

 

Oh, wait, I just realized something else: this bug still exists for the case
where wiki default permissions don't allow edit and no
_ContentBaseDefinition file exists. So it's better than it was, but still
not all the way fixed. I went ahead and committed it anyway, but left the
bug open. And assigned to you. J 

 

From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of John
Davidson
Sent: Sunday, July 22, 2007 2:04 PM
To: FlexWiki Users Mailing List
Subject: [Flexwiki-users] Bug 1735118 UI not Warning

 

Hi Craig

Here is a candidate patch for the bug as described. It will now warn if you
try to create a new Topic in a Namespace or Wiki where you do not have Edit
permission. It does require that the Topic _ContentBaseDefinition exists in
the Namespace. This is not always a valid assumption especially if the wiki
being tested has been created directly by making a Virtual Directory of the
FlexWiki.Web directory of the SVN sources. But it should always work in a
production wiki (I think, if I understand your model correctly)

John Davidson

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Flexwiki-users mailing list
Flexwiki-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flexwiki-users

Reply via email to